Skip to content

Fix check for regex to support new Array#lastIndex proposal #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2021
Merged

Fix check for regex to support new Array#lastIndex proposal #1

merged 1 commit into from
Feb 9, 2021

Conversation

Hypnosphi
Copy link
Contributor

There’s a proposal for Array#lastIndex which may cause a false positive: https://github.com/tc39/proposal-array-last

see 536e7e5#r46933368

@Hypnosphi
Use a safer check for RegExp
7aca4aa 
There’s a proposal for `Array#lastIndex` which may cause a false positive: https://github.com/tc39/proposal-array-last

see syntax-tree@536e7e5#r46933368
@wooorm wooorm changed the title Use a safer check for RegExp Fix check for regex to support new Array#lastIndex proposal Feb 9, 2021
@wooorm wooorm merged commit 28f5e2b into syntax-tree:main Feb 9, 2021
@Hypnosphi Hypnosphi deleted the patch-1 branch February 9, 2021 16:53
@wooorm
Copy link
Member

wooorm commented Feb 9, 2021

Thanks, released! https://github.com/syntax-tree/mdast-util-find-and-replace/releases/tag/1.1.1

@wooorm wooorm added ⛵️ status/released 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix 🗄 area/interface This affects the public interface labels Feb 9, 2021
wooorm added a commit to syntax-tree/hast-util-find-and-replace that referenced this pull request Feb 9, 2021
@wooorm
Fix check for regex to support new Array#lastIndex proposal
1051114 
Related to syntax-tree/mdast-util-find-and-replace#1.
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hypnosphi @wooorm